Skip to content

Conversation

M-Abdoon
Copy link

Learners, PR Template

Self checklist

  • [ x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [x ] My changes meet the requirements of the task
  • [ x] I have tested my changes
  • [x ] My changes follow the style guide

Changelist

I have done the sprint and I answered the questions & corrected the errors.
I learnt about the console, the native functions and understood the basics of JavaScript.

@M-Abdoon M-Abdoon added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 23, 2025
@M-Abdoon M-Abdoon changed the title Glasgow | 25-ITP-SEP | Mohammed Abdoon | Sprint 1 | Coursework Glasgow | 25-ITP-SEP | Mohammed Abdoon | Sprint 1 | Coursework/sprint 1 Sep 25, 2025
@M-Abdoon M-Abdoon changed the title Glasgow | 25-ITP-SEP | Mohammed Abdoon | Sprint 1 | Coursework/sprint 1 Glasgow | 25-ITP-SEP | Mohammed Abdoon | Sprint 1 | Coursework/sprint-1 Sep 25, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this sprint, there's just one file that I think you need to look at again

num = Math.floor(Math.random() * (maximum - minimum) + 1);

//console.log(num);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal in this task is to offer an explanation of what this code is doing - can you add some comments breaking down what this code is doing bit by bit and then offer a general summary of what is happening?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
Yes, I added an explanation of the code, why I made the small change and what the code is actually doing.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 29, 2025
@M-Abdoon M-Abdoon added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 29, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, it looks like you're done with this PR now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and all review comments have been addressed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants